[Refactor] Moveset arrays can no longer hold null values
#4919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DayKev
force-pushed
the
remove-null-from-moveset
branch
from
dcc9922 to
648506e
Compare
…pokerogue into remove-null-from-moveset
SirzBenjie
reviewed
Feb 9, 2025
SirzBenjie
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes the user will see?
N/A
Why am I making these changes?
Movesets being "allowed" to hold
nullvalues causes the need for lots of unnecessary extra null checks, even though if a value were actuallynullit would break things regardless of said checks.What are the changes from a developer perspective?
The type annotations for
Pokemon.moveset,PokemonSummonData.moveset,PokemonData.movesetand the return ofPokemon.getMoveset()were updated to removenull.How to test the changes?
npm run testor just play the game.
Checklist
betaas my base branchnpm run test)[ ] Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?[ ] Have I provided screenshots/videos of the changes (if applicable)?[ ] Have I made sure that any UI change works for both UI themes (default and legacy)?